Framework/Mustache
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace is_object/is_array with switch on gettype

Browse Source 
When checking multiple types, this is ~10% slower in the worst case, and ~30-33% faster for the average and best case.

See #218
This commit is contained in:
Justin Hileman
2014-08-18 05:00:16 -07:00
parent 6859d82e8e
commit 3d37a88f0b
2 changed files with 34 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Mustache/Context.php
+19 -12
View File
@@ -172,19 +172,26 @@ class Mustache_Context
private function findVariableInStack($id, array $stack) private function findVariableInStack($id, array $stack)
{ {
for ($i = count($stack) - 1; $i >= 0; $i--) { for ($i = count($stack) - 1; $i >= 0; $i--) {
if (is_object($stack[$i]) && !($stack[$i] instanceof Closure)) { switch (gettype($stack[$i])) {
case 'object':
if (!($stack[$i] instanceof Closure)) {
// Note that is_callable() *will not work here*
// See https://github.com/bobthecow/mustache.php/wiki/Magic-Methods
if (method_exists($stack[$i], $id)) {
return $stack[$i]->$id();
} elseif (isset($stack[$i]->$id)) {
return $stack[$i]->$id;
} elseif ($stack[$i] instanceof ArrayAccess && isset($stack[$i][$id])) {
return $stack[$i][$id];
}
}
break;
// Note that is_callable() *will not work here* case 'array':
// See https://github.com/bobthecow/mustache.php/wiki/Magic-Methods if (array_key_exists($id, $stack[$i])) {
if (method_exists($stack[$i], $id)) { return $stack[$i][$id];
return $stack[$i]->$id(); }
} elseif (isset($stack[$i]->$id)) { break;
return $stack[$i]->$id;
} elseif ($stack[$i] instanceof ArrayAccess && isset($stack[$i][$id])) {
return $stack[$i][$id];
}
} elseif (is_array($stack[$i]) && array_key_exists($id, $stack[$i])) {
return $stack[$i][$id];
} }
} }
src/Mustache/Template.php
+15 -12
View File
@@ -113,19 +113,22 @@ abstract class Mustache_Template
*/ */
protected function isIterable($value) protected function isIterable($value)
{ {
if (is_object($value)) { switch (gettype($value)) {
return $value instanceof Traversable; case 'object':
} elseif (is_array($value)) { return $value instanceof Traversable;
$i = 0;
foreach ($value as $k => $v) {
if ($k !== $i++) {
return false;
}
}
return true; case 'array':
} else { $i = 0;
return false; foreach ($value as $k => $v) {
if ($k !== $i++) {
return false;
}
}
return true;
default:
return false;
} }
} }