From 582c3278fa5b7ee0e452c13cd3084e13f76328b1 Mon Sep 17 00:00:00 2001 From: Justin Hileman Date: Sun, 15 Aug 2010 06:28:56 -0400 Subject: [PATCH] Add known issue for whitespace, mark whitespace test as skipped. --- README.markdown | 1 + test/MustacheTest.php | 15 +++++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/README.markdown b/README.markdown index ab27846..9512104 100644 --- a/README.markdown +++ b/README.markdown @@ -83,6 +83,7 @@ Known Issues * Sections don't respect delimiter changes -- `delimiters` example currently fails with an "unclosed section" exception. + * Mustache isn't always very good at whitespace. * Test coverage is incomplete. diff --git a/test/MustacheTest.php b/test/MustacheTest.php index a877c03..a2807cf 100644 --- a/test/MustacheTest.php +++ b/test/MustacheTest.php @@ -35,6 +35,11 @@ class MustacheTest extends PHPUnit_Framework_TestCase { const TEST_CLASS = 'Mustache'; + protected $knownIssues = array( + 'Delimiters' => "Known issue: sections don't respect delimiter changes", + 'SectionsSpaces' => "Known issue: Mustache fails miserably at whitespace", + ); + /** * Test Mustache constructor. * @@ -191,9 +196,8 @@ class MustacheTest extends PHPUnit_Framework_TestCase { * @return void */ public function test__clone($class, $template, $output) { - if ($class == 'Delimiters') { - $this->markTestSkipped("Known issue: sections don't respect delimiter changes"); - return; + if (isset($this->knownIssues[$class])) { + return $this->markTestSkipped($this->knownIssues[$class]); } $m = new $class; @@ -222,9 +226,8 @@ class MustacheTest extends PHPUnit_Framework_TestCase { * @return void */ public function testExamples($class, $template, $output) { - if ($class == 'Delimiters') { - $this->markTestSkipped("Known issue: sections don't respect delimiter changes"); - return; + if (isset($this->knownIssues[$class])) { + return $this->markTestSkipped($this->knownIssues[$class]); } $m = new $class;