From c10c966e604f3d5c5da98b45c955a32acb25169c Mon Sep 17 00:00:00 2001 From: Justin Hileman Date: Tue, 25 Mar 2014 19:22:34 -0700 Subject: [PATCH] Refactor to remove duplicate StreamLogger test code --- .../Mustache/Test/Logger/StreamLoggerTest.php | 21 +++++++++++-------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/test/Mustache/Test/Logger/StreamLoggerTest.php b/test/Mustache/Test/Logger/StreamLoggerTest.php index 236deb6..e64c481 100644 --- a/test/Mustache/Test/Logger/StreamLoggerTest.php +++ b/test/Mustache/Test/Logger/StreamLoggerTest.php @@ -14,23 +14,26 @@ */ class Mustache_Test_Logger_StreamLoggerTest extends PHPUnit_Framework_TestCase { - public function testAcceptsFilename() + /** + * @dataProvider acceptsStreamData + */ + public function testAcceptsStream($name, $stream) { - $name = tempnam(sys_get_temp_dir(), 'mustache-test'); - $logger = new Mustache_Logger_StreamLogger($name); + $logger = new Mustache_Logger_StreamLogger($stream); $logger->log(Mustache_Logger::CRITICAL, 'message'); $this->assertEquals("CRITICAL: message\n", file_get_contents($name)); } - public function testAcceptsResource() + public function acceptsStreamData() { - $name = tempnam(sys_get_temp_dir(), 'mustache-test'); - $file = fopen($name, 'a'); - $logger = new Mustache_Logger_StreamLogger($file); - $logger->log(Mustache_Logger::CRITICAL, 'message'); + $one = tempnam(sys_get_temp_dir(), 'mustache-test'); + $two = tempnam(sys_get_temp_dir(), 'mustache-test'); - $this->assertEquals("CRITICAL: message\n", file_get_contents($name)); + return array( + array($one, $one), + array($two, fopen($two, 'a')), + ); } /**