Explorar el Código

Refactor to remove duplicate StreamLogger test code

Justin Hileman hace 11 años
padre
commit
c10c966e60
Se han modificado 1 ficheros con 12 adiciones y 9 borrados
  1. 12 9
      test/Mustache/Test/Logger/StreamLoggerTest.php

+ 12 - 9
test/Mustache/Test/Logger/StreamLoggerTest.php

@@ -14,23 +14,26 @@
  */
 class Mustache_Test_Logger_StreamLoggerTest extends PHPUnit_Framework_TestCase
 {
-    public function testAcceptsFilename()
+    /**
+     * @dataProvider acceptsStreamData
+     */
+    public function testAcceptsStream($name, $stream)
     {
-        $name   = tempnam(sys_get_temp_dir(), 'mustache-test');
-        $logger = new Mustache_Logger_StreamLogger($name);
+        $logger = new Mustache_Logger_StreamLogger($stream);
         $logger->log(Mustache_Logger::CRITICAL, 'message');
 
         $this->assertEquals("CRITICAL: message\n", file_get_contents($name));
     }
 
-    public function testAcceptsResource()
+    public function acceptsStreamData()
     {
-        $name   = tempnam(sys_get_temp_dir(), 'mustache-test');
-        $file   = fopen($name, 'a');
-        $logger = new Mustache_Logger_StreamLogger($file);
-        $logger->log(Mustache_Logger::CRITICAL, 'message');
+        $one = tempnam(sys_get_temp_dir(), 'mustache-test');
+        $two = tempnam(sys_get_temp_dir(), 'mustache-test');
 
-        $this->assertEquals("CRITICAL: message\n", file_get_contents($name));
+        return array(
+            array($one, $one),
+            array($two, fopen($two, 'a')),
+        );
     }
 
     /**