Framework/Mustache
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move loader cascading into the loadPartial method.

Browse Source 
This means the `partialsLoader` property is never set to the default loader, fixing things like `setPartials`, but template loading cascades as per the spec.

Add test coverage for partial cascading.
This commit is contained in:
Justin Hileman
2013-03-12 16:03:58 -07:00
parent 72007e65b4
commit ca44ef68f8
2 changed files with 36 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/Mustache/Test/EngineTest.php
+24 -1
View File
@@ -104,7 +104,7 @@ class Mustache_Test_EngineTest extends PHPUnit_Framework_TestCase
$mustache->setLoader($loader);
$this->assertSame($loader, $mustache->getLoader());
$this->assertSame($loader, $mustache->getPartialsLoader());
$this->assertNotSame($loader, $mustache->getPartialsLoader());
$mustache->setPartialsLoader($loader);
$this->assertSame($loader, $mustache->getPartialsLoader());
@@ -240,6 +240,29 @@ class Mustache_Test_EngineTest extends PHPUnit_Framework_TestCase
$mustache->setLogger(new StdClass);
}
public function testLoadPartialCascading()
{
$loader = new Mustache_Loader_ArrayLoader(array(
'foo' => 'FOO',
));
$mustache = new Mustache_Engine(array('loader' => $loader));
$tpl = $mustache->loadTemplate('foo');
$this->assertSame($tpl, $mustache->loadPartial('foo'));
$mustache->setPartials(array(
'foo' => 'f00',
));
// setting partials overrides the default template loading fallback.
$this->assertNotSame($tpl, $mustache->loadPartial('foo'));
// but it didn't overwrite the original template loader templates.
$this->assertSame($tpl, $mustache->loadTemplate('foo'));
}
public function testPartialLoadFailLogging()
{
$name = tempnam(sys_get_temp_dir(), 'mustache-test');