From f34f6699c21a6f9c0947514d07c810255d28dde4 Mon Sep 17 00:00:00 2001 From: Justin Hileman Date: Mon, 25 Aug 2014 11:18:09 -0700 Subject: [PATCH] Increase test coverage. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit … fix a bug exposed by increased test coverage :-/ --- src/Mustache/Loader/FilesystemLoader.php | 2 +- test/Mustache/Test/EngineTest.php | 10 +++++++ test/Mustache/Test/ParserTest.php | 36 ++++++++++++++++++++++++ 3 files changed, 47 insertions(+), 1 deletion(-) diff --git a/src/Mustache/Loader/FilesystemLoader.php b/src/Mustache/Loader/FilesystemLoader.php index 8a27b01..7cbf9cd 100644 --- a/src/Mustache/Loader/FilesystemLoader.php +++ b/src/Mustache/Loader/FilesystemLoader.php @@ -49,7 +49,7 @@ class Mustache_Loader_FilesystemLoader implements Mustache_Loader { $this->baseDir = $baseDir; - if (strpos($this->baseDir, '://') === -1) { + if (strpos($this->baseDir, '://') === false) { $this->baseDir = realpath($this->baseDir); } diff --git a/test/Mustache/Test/EngineTest.php b/test/Mustache/Test/EngineTest.php index c437a04..f61f876 100644 --- a/test/Mustache/Test/EngineTest.php +++ b/test/Mustache/Test/EngineTest.php @@ -321,6 +321,16 @@ class Mustache_Test_EngineTest extends Mustache_Test_FunctionalTestCase $this->assertContains("WARNING: Partial not found: \"bar\"", $log); } + /** + * @expectedException Mustache_Exception_InvalidArgumentException + */ + public function testUnknownPragmaThrowsException() + { + new Mustache_Engine(array( + 'pragmas' => array('UNKNOWN') + )); + } + private function getLoggedMustache($level = Mustache_Logger::ERROR) { $name = tempnam(sys_get_temp_dir(), 'mustache-test'); diff --git a/test/Mustache/Test/ParserTest.php b/test/Mustache/Test/ParserTest.php index 08aed5b..eccfc3d 100644 --- a/test/Mustache/Test/ParserTest.php +++ b/test/Mustache/Test/ParserTest.php @@ -149,6 +149,42 @@ class Mustache_Test_ParserTest extends PHPUnit_Framework_TestCase ), ), ), + + array( + array( + array( + Mustache_Tokenizer::TYPE => Mustache_Tokenizer::T_TEXT, + Mustache_Tokenizer::LINE => 0, + Mustache_Tokenizer::VALUE => " ", + ), + array( + Mustache_Tokenizer::TYPE => Mustache_Tokenizer::T_DELIM_CHANGE, + Mustache_Tokenizer::LINE => 0, + ), + array( + Mustache_Tokenizer::TYPE => Mustache_Tokenizer::T_TEXT, + Mustache_Tokenizer::LINE => 0, + Mustache_Tokenizer::VALUE => " \n", + ), + array( + Mustache_Tokenizer::TYPE => Mustache_Tokenizer::T_ESCAPED, + Mustache_Tokenizer::NAME => 'foo', + Mustache_Tokenizer::OTAG => '[[', + Mustache_Tokenizer::CTAG => ']]', + Mustache_Tokenizer::LINE => 1, + ), + ), + array( + array( + Mustache_Tokenizer::TYPE => Mustache_Tokenizer::T_ESCAPED, + Mustache_Tokenizer::NAME => 'foo', + Mustache_Tokenizer::OTAG => '[[', + Mustache_Tokenizer::CTAG => ']]', + Mustache_Tokenizer::LINE => 1, + ), + ), + ), + ); }